Mail Index


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ApacheGallery] Fw: modules/gallery/lib/Apache (Gallery.pm): Provide our own, perhaps not broken, version of uri_escape



Sadly, this new escape string still has an escaped slash...
my $escape_rule = "^A-Za-z0-9\-_.!~*'()\/";

However, reviewing my error message:

[Mon Mar 18 18:14:32 2002] [error] uri_escape: [Mon Mar 18 18:14:32 2002]
(eval 159): /([^A-Za-z0-9-_.!~*'()/: unmatched [] in regexp at (eval 159)
line 1.

Gave me the following idea... why not escape it twice if the passing of it
nulls the first escape?

My testing with
my $escape_rule = "^A-Za-z0-9\-_.!~*'()\\/";

Is successful. Is yours?

Thanks for working so hard on this. If at any point you decide that you
would like to make perl 5.6.1 a prerequisite, just let me know and I'll drop
it all. :-)

Best,
Paul
----- Original Message -----
From: "Michael Legart" <[email protected]>
To: <[email protected]>
Sent: Sunday, March 17, 2002 5:12 AM
Subject: Re: [ApacheGallery] Fw: modules/gallery/lib/Apache (Gallery.pm):
Provide our own, perhaps not broken, version of uri_escape


> On Wed, Mar 13, 2002 at 01:35:03PM -0500, Paul Vallee wrote:
> > 1.72 generates this html for the picture with the accented characters:
> >     <a href="/2002_02_14 Nicole TC goodbye party/Nicole et
Hélène.jpg"><img
> > alt="Nicole et  Hélène.jpg - "
> >
src="/2002_02_14%20Nicole%20TC%20goodbye%20party/.cache/100x75%2DNicole%20et
> > %20%20H%E9l%E8ne.jpg"></a>
>
> Woups, there was a missing escape on one of the strings, fixed.
>
> > Notice that now none of it is escapes, and as such not only does the
link
> > 404 but also the thumbnail has a broken image.
>
> My hack with a custom uri_escape didn't work very well so i
> removed it agian. It looks like the current escape rule works
> with both perl 5.6.0 and perl 5.6.1 - can you check that it
> works on 5.6.0?
>
> I have updated the
http://apachegallery.dk/download/Apache-Gallery-dev.tar.gz
> to latest CVS.
>
> Thanks
>
> Michael
>
> ---------------------------------------------------------------------
> Apache::Gallery users mailinglist. http://apachegallery.dk/
> To unsubscribe, e-mail: [email protected]
>
>
>



---------------------------------------------------------------------
Apache::Gallery users mailinglist. http://apachegallery.dk/
To unsubscribe, e-mail: [email protected]