Mail Index


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [ApacheGallery] Bug w/ GalleryCopyrightImage



The problem, I believe, with that fix, is that is will still print the error message.
it was originally (In summary)

if (-f $copyrightfile and (my $logo=Image::Imlib2->load($copyrightfile))) {
	stuff
}
else {
	print error
}

With the patch, it will still return false for the if

if (($copyrightfile ne '') and (-f $copyrightfile) and (my $logo=Image::Imlib2->load($copyrightfile))) {
	stuff
}
else {
	print error
}

-----Original Message-----
From: [email protected]
[mailto:[email protected]]On Behalf Of Michael Legart
Sent: Monday, September 29, 2003 1:43 PM
To: [email protected]
Subject: Re: [ApacheGallery] Bug w/ GalleryCopyrightImage


Gentlemen

On Mon, Sep 29, 2003 at 08:40:38PM +0200, Andreas Plesner Jacobsen wrote:
> 
> I've fixed it with:
> -       if (-f $copyrightfile and (my $logo=Image::Imlib2->load($copyrightfile))) {
> +       if (($copyrightfile ne '') and (-f $copyrightfile) and (my $logo=Image::Imlib2->load($copyrightfile))) {
> 
> And committed the fix to r216. It should appear as a snapshot when
> Michael sees this.

Thank you!

http://svn.apachegallery.dk/snapshots/Apache-Gallery-r216.tar.gz

-- 
hestdesign.info - we put the hest in .com
_______________________________________________
users mailing list
[email protected]
http://ufo.hestdesign.com/cgi-bin/mailman/listinfo/agusers

_______________________________________________
users mailing list
[email protected]
http://ufo.hestdesign.com/cgi-bin/mailman/listinfo/agusers