Mail Index


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [ApacheGallery] Bug w/ GalleryCopyrightImage



I really think it is effecting everyone, they just may not be checking their logs.  I think it is a more recent bug
though, I don't remember seeing it before a few weeks ago.  I usually install the latest release within 2-3 days of
upload.


-----Original Message-----
From: [email protected]
[mailto:[email protected]]On Behalf Of [email protected]
Sent: Monday, September 29, 2003 1:57 PM
To: [email protected]
Subject: Re: [ApacheGallery] Bug w/ GalleryCopyrightImage



Thanks Christopher, I've been having trouble with this error myself.  I ended up
commenting out that whole section of code.  Why do you think we had this issue
where lots of other users were unaffected?

On Mon, 29 Sep 2003, Christopher Knight wrote:

> I am getting random errors in apache's logs:
>
> "[error] GalleryCopyrightImage  was not found"
>
> I do not have GalleryCopyrightImage defined in my httpd.conf.
>
> I chased it down in the code (r215).  The problem is in sub resizepicture.
> It prints an error meant for invalid file names.
>
> Here is a diff that fixes it (It's all really in the first new line line, everything else is just indented over):
>
> -       if (-f $copyrightfile and (my $logo=Image::Imlib2->load($copyrightfile))) {
> -               my $x = $image->get_width();
> -               my $y = $image->get_height();
> -               my $logox = $logo->get_width();
> -               my $logoy = $logo->get_height();
> -               $image->blend($logo, 0, 0, 0, $logox, $logoy, $x-$logox, $y-$logoy, $logox, $logoy);
> -       }
> -       else {
> -               Apache->request->log_error("GalleryCopyrightImage $copyrightfile was not found\n");
> -       }
> +  if ($copyrightfile ne '') {
> +    if (-f $copyrightfile and (my $logo=Image::Imlib2->load($copyrightfile))) {
> +      my $x = $image->get_width();
> +      my $y = $image->get_height();
> +      my $logox = $logo->get_width();
> +      my $logoy = $logo->get_height();
> +      $image->blend($logo, 0, 0, 0, $logox, $logoy, $x-$logox, $y-$logoy, $logox, $logoy);
> +    }
> +    else {
> +      Apache->request->log_error("GalleryCopyrightImage $copyrightfile was not found\n");
> +    }
> +  }
> _______________________________________________
> users mailing list
> [email protected]
> http://ufo.hestdesign.com/cgi-bin/mailman/listinfo/agusers
>

--

Zak Brown
www.mode3.com

--

"I'm not one of those button luddites that's all like anti-zipper."


_______________________________________________
users mailing list
[email protected]
http://ufo.hestdesign.com/cgi-bin/mailman/listinfo/agusers

_______________________________________________
users mailing list
[email protected]
http://ufo.hestdesign.com/cgi-bin/mailman/listinfo/agusers