Mail Index


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [ApacheGallery] Patch to replace inline C code with native Perl



Jon,
Even with when I'm using Image::Magick I'm getting the same errors in the
logs..

Here are the errors

 [Sat Mar 22 17:57:40 2003] [error] Undefined subroutine
&Apache::Gallery::resizepicture called at
/usr/local/lib/perl5/site_perl/5.7.2/Apache/Gallery.pm line 662.

[Sat Mar 22 17:57:41 2003] [error] Undefined subroutine
&Apache::Gallery::resizepicture called at
/usr/local/lib/perl5/site_perl/5.7.2/Apache/Gallery.pm line 662.

Also I'm getting these errors

[CGI::FastTemplate] Warning: no value found for variable: THUMB_WIDTH
[CGI::FastTemplate] Warning: no value found for variable: THUMB_HEIGHT




-----Original Message-----
From: Jon McClintock [mailto:[email protected]] 
Sent: Saturday, March 22, 2003 1:49 PM
To: Thomas Eibner
Cc: [email protected]
Subject: Re: [ApacheGallery] Patch to replace inline C code with native Perl

On Wed, Mar 12, 2003 at 09:00:58PM -0800, Jon McClintock wrote:
> This is a good point. I tried it out just now: on a directory with 117 
> 1600x1200 images, the load spiked up to 4.25. It only took a couple of
> minutes to produce the thumbnails for the whole directory, though. And, 
> the client didn't time out while loading the page (in the current
> version, the client times out several times while waiting for the HTML
> to unblock on the resize).
> 
> Keep in mind, you'll only experience that load while it populates the
> cache.
> 
> I'll test it a little more and send a patch out.

Ok, as promised, here is an updated version of my patch. In addition to
my previous changes, it modifies Apache::Gallery to not resize the
images until the image fetch. To appease those who objected, I added 
a configuration variable "GalleryResizeOnPageFetch". If it's set, the
original behavior is retained, and images are resized when the index
page is generated. If it's not set, images aren't resized until they are
requested specifically.

-Jon